Skip to content

[Merged by Bors] - feat(AlgebraicGeometry): Pushforward of algebraic cycles#26304

Closed
Raph-DG wants to merge 14 commits into
leanprover-community:masterfrom
Raph-DG:Raph-DG-AlgebraicCycle
Closed

[Merged by Bors] - feat(AlgebraicGeometry): Pushforward of algebraic cycles#26304
Raph-DG wants to merge 14 commits into
leanprover-community:masterfrom
Raph-DG:Raph-DG-AlgebraicCycle

Conversation

@Raph-DG

@Raph-DG Raph-DG commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 23, 2025

Copy link
Copy Markdown

PR summary 4b3db1614d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.LocallyFinsupp.Pushforward (new file) 946

Declarations diff

+ coe_mk
+ map
+ map_apply
+ map_id
+ support_map_subset_of_forall_mem
+ toFun_eq_coe

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 23, 2025
@Raph-DG Raph-DG added the RFC Request for comment label Jun 23, 2025
@leanprover-community-bot-assistant

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 27, 2025
@grunweg grunweg added the t-algebraic-geometry Algebraic geometry label Aug 4, 2025
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 18, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 18, 2026
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp.lean
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/AlgebraicCycle.lean Outdated
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 24, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 26, 2026
@Raph-DG Raph-DG removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 26, 2026
@chrisflav

Copy link
Copy Markdown
Member

After some discussion with Andrew, the following is my suggestion for this PR:

  • Define a pushforward for Function.locallyFinsupp for prespectral and sober topological spaces taking a weight function as an argument X → R, which is what replaces the mapAux (the proof might require some more topological assumptions, of which we can of course assume the ones that are true in the application).
  • Given s : Set X, t : Set Y and a Function.locallyFinsupp with support in s, there should be a lemma showing that, under some compatibility with the weights, the image of the pushforward has support in t.
  • This will then induce a map between the "homogeneous cycles", which is just the additive submonoid of cycles with support in a given set.

In the next PR, I would suggest to:

  • Add the abbrev for AlgebraicCycle as it is done here.
  • Define the weights function for a morphism of schemes as you do here, but make it Nat-valued. This will still allow to apply the above construction by coercing the Nats to elements of the coefficient ring.
  • Remove Grading and HasDegree.

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 7, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Mar 12, 2026
…lyFinsuppWithin (#35807)

In this PR, we generalised the various instances for locally fin supp functions. These changes were originally made on the PR #26304 about algebraic cycles, but it was decided that these changes are more appropriate in their own PR.

Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 12, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 12, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2026
@Raph-DG Raph-DG removed awaiting-author A reviewer has asked the author a question or requested changes. RFC Request for comment labels Apr 1, 2026
@Raph-DG Raph-DG changed the title feat(AlgebraicGeometry): Definition of algebraic cycles feat(AlgebraicGeometry): Pushforward of algebraic cycles Apr 8, 2026
@Raph-DG

Raph-DG commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

After some discussion with Andrew, the following is my suggestion for this PR:

  • Define a pushforward for Function.locallyFinsupp for prespectral and sober topological spaces taking a weight function as an argument X → R, which is what replaces the mapAux (the proof might require some more topological assumptions, of which we can of course assume the ones that are true in the application).
  • Given s : Set X, t : Set Y and a Function.locallyFinsupp with support in s, there should be a lemma showing that, under some compatibility with the weights, the image of the pushforward has support in t.
  • This will then induce a map between the "homogeneous cycles", which is just the additive submonoid of cycles with support in a given set.

In the next PR, I would suggest to:

  • Add the abbrev for AlgebraicCycle as it is done here.
  • Define the weights function for a morphism of schemes as you do here, but make it Nat-valued. This will still allow to apply the above construction by coercing the Nats to elements of the coefficient ring.
  • Remove Grading and HasDegree.

What's here I think fulfils this, but I now think it's probably more sensible design-wise to directly use Function.locallyFinsuppWithin to talk about locally finsupp functions with support in s. I'm temporarily making this PR WIP to try and do such a refactor.

Edit: Christian already knows this, but for anyone else who happens to be reading this, we realised this idea does not quite work so I've reverted this to the state it was in before I attempted the refactor and have removed the WIP label

@Raph-DG Raph-DG removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 21, 2026

@chrisflav chrisflav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more nit-picks, but this is converging quickly now!

Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label May 26, 2026
Raph-DG and others added 11 commits May 26, 2026 14:16
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Comment thread Mathlib/Topology/LocallyFinsupp/Pushforward.lean Outdated
Co-authored-by: Christian Merten <christian@merten.dev>
@Raph-DG Raph-DG removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 26, 2026

@chrisflav chrisflav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 26, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

@joelriou can you have a final look?

@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 5, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 5, 2026
In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support. 

- [x] depends on: #26225
- [x] depends on: #26259 
- [x] depends on: #35807

Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
@mathlib-bors

mathlib-bors Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(AlgebraicGeometry): Pushforward of algebraic cycles [Merged by Bors] - feat(AlgebraicGeometry): Pushforward of algebraic cycles Jun 5, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 5, 2026
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…community#26304)

In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support. 

- [x] depends on: leanprover-community#26225
- [x] depends on: leanprover-community#26259 
- [x] depends on: leanprover-community#35807

Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
mathlib-bors Bot pushed a commit that referenced this pull request Jun 25, 2026
In this PR we define the notion of algebraic cycles on a scheme, and define the pushforward of an algebraic cycle by a quasicompact morhphism. This was originally defined in #26304, but after some refactoring it was decided that it would be best to split this definition into a separate PR.

Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants