[Merged by Bors] - feat(AlgebraicGeometry): Pushforward of algebraic cycles#26304
[Merged by Bors] - feat(AlgebraicGeometry): Pushforward of algebraic cycles#26304Raph-DG wants to merge 14 commits into
Conversation
PR summary 4b3db1614dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
|
After some discussion with Andrew, the following is my suggestion for this PR:
In the next PR, I would suggest to:
|
…lyFinsuppWithin (#35807) In this PR, we generalised the various instances for locally fin supp functions. These changes were originally made on the PR #26304 about algebraic cycles, but it was decided that these changes are more appropriate in their own PR. Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
|
This pull request has conflicts, please merge |
What's here I think fulfils this, but I now think it's probably more sensible design-wise to directly use Function.locallyFinsuppWithin to talk about locally finsupp functions with support in s. I'm temporarily making this PR WIP to try and do such a refactor. Edit: Christian already knows this, but for anyone else who happens to be reading this, we realised this idea does not quite work so I've reverted this to the state it was in before I attempted the refactor and have removed the WIP label |
chrisflav
left a comment
There was a problem hiding this comment.
Some more nit-picks, but this is converging quickly now!
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
|
@joelriou can you have a final look? |
|
Thanks! bors merge |
In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support. - [x] depends on: #26225 - [x] depends on: #26259 - [x] depends on: #35807 Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
…community#26304) In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support. - [x] depends on: leanprover-community#26225 - [x] depends on: leanprover-community#26259 - [x] depends on: leanprover-community#35807 Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
In this PR we define the notion of algebraic cycles on a scheme, and define the pushforward of an algebraic cycle by a quasicompact morhphism. This was originally defined in #26304, but after some refactoring it was decided that it would be best to split this definition into a separate PR. Co-authored-by: Raph-DG <raphaeldouglasgiles@gmail.com>
In this PR we define a notion of the "pushfoward of functions with locally finite support". We give this PR the suggestive title "pushforward of algebraic cycles" because we will go on to model algebraic cycles on a scheme X as functions from X to the integers with locally finite support.